This repository has been archived by the owner on Mar 14, 2019. It is now read-only.
Redesign monitoring internals #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treating the rake task as the public interface here, but this would break anyone using the stuff in lib/monitoring * Created a real data type for the results of checks * Removed the "per queue" notifier, which was tightly coupled to its checker. Now librato notifier can handle all of them * This should make it easier to add more advanced checks/notifications. To get confidence this won't break anything, I basically made the internal changes and kept running the monitoring integration test. Once I'd made all the changes without that breaking, I then updated the unit tests. (The change in the monitoring integration test was just to add failure messages to the asserts. No actual changes were made)
| @@ -0,0 +1,30 @@ | |||
| module Monitoring | |||
| class CheckResult | |||
There was a problem hiding this comment.
This now captures the contract between checker and notifier. Before it was basically whatever and so it resulted in tight coupling between some checkers and notifiers.
davetron5000
added a commit
that referenced
this pull request
Jan 31, 2016
Redesign monitoring internals
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treating the rake task as the public interface here, but this would break anyone using the stuff in lib/monitoring
To get confidence this won't break anything, I basically made the internal changes and kept running the monitoring integration test. Once I'd made all the changes without that breaking, I then updated the unit tests.
(The change in the monitoring integration test was just to add failure messages to the asserts. No actual changes were made)
This is in advance of another change I'm going to make to add stats around the class of failed jobs, so we can treat certain failures as more urgent than others without having to create a custom resque error handler. Wanted to get feedback on this first, which will make the overall change easier to understand (hopefully :)